fix: parse REGISTER response Contact headers#103
Merged
shenjinti merged 1 commit intorestsend:mainfrom Mar 13, 2026
Merged
Conversation
yeoleobun
force-pushed
the
yeoleobun/fix-register-response-contact
branch
from
43a55af to
6cffbdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.contact = contact.typed().ok();inregistration.rswill fail when there are multiple Contact in the Contact Header and it also fail when receive Contact from Kamaillio like this:Since there are many place may need this work around, so i add an new function
typed_contact_headers