Skip to content

Issue #1487: use ThreadLocalRandom to generate random number in Route… #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thboileau merged 1 commit into from
Mar 8, 2026
Merged

Issue #1487: use ThreadLocalRandom to generate random number in Route… #1494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions org.restlet.java/org.restlet/src/main/java/org/restlet/util/RouteList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
import org.restlet.Restlet;
import org.restlet.routing.Route;

import java.security.SecureRandom;
import java.util.Collections;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.ThreadLocalRandom;

/**
* Modifiable list of routes with some helper methods. Note that this class
Expand All @@ -36,8 +36,6 @@
public final class RouteList extends WrapperList<Route> {
/** The index of the last route used in the round-robin mode. */
private volatile int lastIndex;
/** Used when asked to return a random route. */
private final SecureRandom random = new SecureRandom();

/**
* Constructor.
Expand Down Expand Up @@ -161,7 +159,7 @@ public synchronized Route getRandom(Request request, Response response, float re
int length = size();

if (length > 0) {
int j = random.nextInt(length);
int j = ThreadLocalRandom.current().nextInt(length);
Route route = get(j);

if (route.score(request, response) >= requiredScore) {
Expand Down