New executor defaults for handler runner #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
commented
Jan 26, 2026
| + "If you need to customize the thread pool used by your restate handlers, " | ||
| + "use HandlerRunner.Options.withExecutor() with Endpoint.bind()"); | ||
|
|
||
| return Executors.newCachedThreadPool(); |
Contributor
Author
There was a problem hiding this comment.
I'm torn on this one. On one hand, we should use a bounded executor as described here #580 (comment)
On the other hand, i'm worried that this is gonna cause some breaking changes wrt to Java < 21 users: an undersized queue will certainly cause a flood of failing invocations for some existing users, because of this artificial bound we would introduce here.
slinkydeveloper
force-pushed
the
issues/580
branch
from
b627ef7 to
e933876
Compare
Contributor
slinkydeveloper
force-pushed
the
issues/580
branch
from
e933876 to
83d4909
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #580