-
Notifications
You must be signed in to change notification settings - Fork 64
fix: update globs to work on windows with WSL #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: update globs to work on windows with WSL #1178
Conversation
be5828d to
b08ca4b
Compare
b08ca4b to
d9c5d7b
Compare
cristianoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Nit: there are more lines changed than needed, kind of makes it difficult to see the actual differences.
|
Also, any thoughts to prevent regressions here? |
|
@cristianoc can the recent e2e test setup help here? |
It can if tests work on windows. Anyone with a win machine can try to run this: cd client
npm test |
nojaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works for me on Mac.
@jderochervlk can you add some entries in the CHANGELOG.md please.
|
On windows, no WSL, running |
e1d7c25 to
5165a1b
Compare
5165a1b to
536ac75
Compare
I removed some of the extra changes to minimize the difference. |
Added a note to the changelog. |
This was mostly trial and error to figure out, but eventually I got it working.
Paths for WSL resolve differently so the simple glob pattern wasn't working.
Instead of setting
globPatternas a string I changed them to definebaseUriandpatternas separate values.This only works when you have
incrementalTypecheckingenabled, but I like that anyway. We might want to document that for windows users.Before
Index.res.-.rescript-lang.org.WSL_.Ubuntu-22.04.-.Visual.Studio.Code.2026-02-02.15-46-47.mp4
After
Index.res.-.rescript-lang.org.WSL_.Ubuntu-22.04.-.Visual.Studio.Code.2026-02-02.15-40-42.mp4