Skip to content

Conversation

@jderochervlk
Copy link
Contributor

@jderochervlk jderochervlk commented Feb 2, 2026

This was mostly trial and error to figure out, but eventually I got it working.

Paths for WSL resolve differently so the simple glob pattern wasn't working.

Instead of setting globPattern as a string I changed them to define baseUri and pattern as separate values.

This only works when you have incrementalTypechecking enabled, but I like that anyway. We might want to document that for windows users.

Before

Index.res.-.rescript-lang.org.WSL_.Ubuntu-22.04.-.Visual.Studio.Code.2026-02-02.15-46-47.mp4

After

Index.res.-.rescript-lang.org.WSL_.Ubuntu-22.04.-.Visual.Studio.Code.2026-02-02.15-40-42.mp4

@jderochervlk jderochervlk force-pushed the vlk/update-globs-to-fix-wsl branch 2 times, most recently from be5828d to b08ca4b Compare February 2, 2026 19:55
@jderochervlk jderochervlk force-pushed the vlk/update-globs-to-fix-wsl branch from b08ca4b to d9c5d7b Compare February 2, 2026 20:30
@jderochervlk jderochervlk requested a review from nojaf February 2, 2026 20:32
@jderochervlk jderochervlk marked this pull request as ready for review February 2, 2026 20:38
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
Nit: there are more lines changed than needed, kind of makes it difficult to see the actual differences.

@cristianoc
Copy link
Collaborator

Also, any thoughts to prevent regressions here?
Seems like it will very easily happen again as soon as the code is edited.

@zth
Copy link
Member

zth commented Feb 3, 2026

@cristianoc can the recent e2e test setup help here?

@cristianoc
Copy link
Collaborator

@cristianoc can the recent e2e test setup help here?

It can if tests work on windows. Anyone with a win machine can try to run this:

cd client
npm test

Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works for me on Mac.
@jderochervlk can you add some entries in the CHANGELOG.md please.

@jderochervlk
Copy link
Contributor Author

jderochervlk commented Feb 4, 2026

On windows, no WSL, running npm test fails on master and on this branch.

[main 2026-02-04T00:20:14.166Z] Error: Error mutex already exists
    at qu.S (file:///F:/Dev/rescript-vscode/client/.vscode-test/vscode-win32-x64-archive-1.108.2/resources/app/out/main.js:142:18405)

@jderochervlk jderochervlk force-pushed the vlk/update-globs-to-fix-wsl branch from e1d7c25 to 5165a1b Compare February 4, 2026 00:27
@jderochervlk jderochervlk force-pushed the vlk/update-globs-to-fix-wsl branch from 5165a1b to 536ac75 Compare February 4, 2026 00:29
@jderochervlk
Copy link
Contributor Author

Thanks for the fix. Nit: there are more lines changed than needed, kind of makes it difficult to see the actual differences.

I removed some of the extra changes to minimize the difference.

@jderochervlk
Copy link
Contributor Author

Still works for me on Mac. @jderochervlk can you add some entries in the CHANGELOG.md please.

Added a note to the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants