TimeHandle: Initialize TotalElapsedTime to NearestSyncPoint#135
Open
sean-anderson-seco wants to merge 1 commit intorenode:masterfrom
Open
TimeHandle: Initialize TotalElapsedTime to NearestSyncPoint#135sean-anderson-seco wants to merge 1 commit intorenode:masterfrom
sean-anderson-seco wants to merge 1 commit intorenode:masterfrom
Conversation
When registering a new TimeHandle, IsReadyForNewTimeGrant will be true. However, other handles may have already been granted time. The TimeSource will wait for these other active handles to finish (causing their TotalElapsedTime to increase). After all all active handles have finished, SynchronizeVirtualTime will attempt to update the TimeSource's ElapsedVirtualTime. However, the newly-added handle's TotalElapsedTime will still be the source's ElapsedVirtualTime from when the handle was added. This will prevent time from advancing. This will cause ExecuteSyncPhase to fail, since ElapsedVirtualTime will not equal NearestSyncPoint. Fix this by initializing TimeHandle.TotalElapsedTime to TimeSource.NearestSyncPoint, which is the earliest time that time will be granted to the handle. Fixes: 49d06a3 ("[#8661] Introduce new time framework.")
|
Sean Anderson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering a new TimeHandle, IsReadyForNewTimeGrant will be true. However, other handles may have already been granted time. The TimeSource will wait for these other active handles to finish (causing their TotalElapsedTime to increase). After all all active handles have finished, SynchronizeVirtualTime will attempt to update the TimeSource's ElapsedVirtualTime. However, the newly-added handle's TotalElapsedTime will still be the source's ElapsedVirtualTime from when the handle was added. This will prevent time from advancing. This will cause ExecuteSyncPhase to fail, since ElapsedVirtualTime will not equal NearestSyncPoint.
Fix this by initializing TimeHandle.TotalElapsedTime to TimeSource.NearestSyncPoint, which is the earliest time that time will be granted to the handle.
Fixes: 49d06a3 ("[#8661] Introduce new time framework.")