Prevent an out of bounds from trying to access comments[0].author.name when there are no comments#542
Open
ButteredCats wants to merge 1 commit intoredlib-org:mainfrom
Open
Conversation
…e when there are no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #496.
This can happen naturally when trying to view a comment that has been totally deleted from Reddit (where they warn "This comment no longer exists"), but can also be triggered intentionally by entering a nonsense comment ID.
With this PR the post is viewable and no comments appear when this happens, but this gives no warning that the comment was fully deleted or was invalid. I also created a version where an error page is display instead, but since that prevents you from seeing the post I decided this was the better option instead.
I'd prefer some way of having a warning about the comment being gone while still being able to view the post but I'm not sure there's any easy way to do this.