add basic support for declaring schema with inline $schema#970
Open
bollwyvl wants to merge 9 commits intoredhat-developer:mainfrom
Open
add basic support for declaring schema with inline $schema#970bollwyvl wants to merge 9 commits intoredhat-developer:mainfrom
$schema#970bollwyvl wants to merge 9 commits intoredhat-developer:mainfrom
Conversation
7e9164e to
d40208e
Compare
d40208e to
6767a56
Compare
940bc69 to
3c155e8
Compare
3c155e8 to
1f7c659
Compare
Contributor
Author
|
Looking more through older PRs and issues:
it appears some of the relevant argument there was in somehow ignoring |
This was referenced May 18, 2024
Contributor
Author
|
I see 1.15.0 went out 🎉... what can I do to help this get into the review pipeline, and hopefully make it into the next release? |
|
Can this be prioritized? @msivasubramaniaan |
3 tasks
Contributor
Author
|
Updated to latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
$schema# yaml-language-server $schema=What issues does this PR fix or reference?
"$schema":for current JSON file #964Is it tested? How?
test/fixtures/sample-dollar-schema.jsonaddedtest/schema.test.ts$schema(which it ignores)$schema(which beats settings)