Introduce VS Code/JDTLS formatter scheme#3059
Open
CsCherrYY wants to merge 1 commit intoredhat-developer:mainfrom
Open
Introduce VS Code/JDTLS formatter scheme#3059CsCherrYY wants to merge 1 commit intoredhat-developer:mainfrom
CsCherrYY wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Shi Chen <chenshi@microsoft.com>
b112ae4 to
a8a8cda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires eclipse-jdtls/eclipse.jdt.ls#2589
This PR introduces a VS Code/JDTLS formatter scheme, which can be configured without existing eclipse profile.
Deprecate configurations:
java.format.settings.urljava.format.settings.profileNew configurations:
java.format.schemeThe configuration accepts both two kinds of values: "string" and "object".
String
Directly configure the formatter scheme. The default value is
eclipse, some popular scheme likegooglecan be introduced in the future.example:
Object
Configure the formatter scheme. It has 4 properties:
eclipse, some popular scheme likegooglecan be introduced in the future.java.format.settings.url, will be ignored if the current style is noteclipse.java.format.settings.profile, will be ignored if the current style is noteclipse.eclipse.example1: Use default eclipse configuration, but set the brace position of blocks to next line:
example2: Use custom eclipse configuration in profile
customfrom file.vscode/java-formatter.xml, but set the brace position of blocks to next line:Configurations list
The first version of the configurations list would be the settings mentioned in formatter related issues in https://github.com/redhat-developer/vscode-java and https://github.com/eclipse/eclipse.jdt.ls, they would be easily configured by the users so that we expose them to convenient editing.
We can also expand the list if there are requests.