[QA] Add StructArmed to QA

.github/workflows/code_analysis.yaml

@@ -79,6 +79,10 @@ jobs:
                             composer require php-parallel-lint/php-parallel-lint --ansi
                             vendor/bin/parallel-lint src bin/rector config tests rules --colors
 
+                    -
+                        name: 'Run StructArmed'
+                        run: vendor/bin/structarmed analyze
+
         name: ${{ matrix.actions.name }}
         runs-on: ubuntu-latest
         timeout-minutes: 10

composer.json

@@ -42,9 +42,9 @@
         "webmozart/assert": "^2.3"
     },
     "require-dev": {
+        "boundwize/structarmed": "^0.5.4",
         "nette/robot-loader": "^4.1",
         "php-parallel-lint/php-parallel-lint": "^1.4",
-        "symplify/easy-coding-standard": "^13.1",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-phpunit": "^2.0",
@@ -55,6 +55,7 @@
         "rector/swiss-knife": "^2.3",
         "rector/type-perfect": "^2.1.2",
         "shipmonk/composer-dependency-analyser": "^1.8",
+        "symplify/easy-coding-standard": "^13.1",
         "symplify/phpstan-extensions": "^12.0.2",
         "symplify/phpstan-rules": "^14.9.11",
         "symplify/vendor-patches": "^11.5",

rules-tests/Assert/Rector/ClassMethod/AddAssertArrayFromClassMethodDocblockRector/BeberleiTest.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Assert\Rector\ClassMethod\AddAssertArrayFromClassMethodDocblockRector;
+namespace Rector\Tests\Assert\Rector\ClassMethod\AddAssertArrayFromClassMethodDocblockRector;
 
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;

rules-tests/CodingStyle/Rector/Catch_/CatchExceptionNameMatchingTypeRector/Source/Notification.php

@@ -1,6 +1,8 @@
 <?php
 
-namespace Rector\CodingStyle\Rector\Catch_\CatchExceptionNameMatchingTypeRector\Source;
+declare(strict_types=1);
+
+namespace Rector\Tests\CodingStyle\Rector\Catch_\CatchExceptionNameMatchingTypeRector\Source;
 
 class Notification
 {

rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/RecastingRemovalRectorPhp74Test.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace DeadCode\Rector\Cast\RecastingRemovalRector;
+namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector;
 
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;

rules-tests/DeadCode/Rector/ClassMethod/RemoveUnusedPublicMethodParameterRector/Source/InterfaceWithMethod.php

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPublicMethodParameterRector\Source;
 
-interface interfaceWithMethod
+interface InterfaceWithMethod
 {
     public function run($a, $b);
 }

rules-tests/DeadCode/Rector/FunctionLike/NarrowWideUnionReturnTypeRector/Fixture/final_inheritance.php.inc

@@ -4,7 +4,7 @@
 namespace Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Fixture;
 
 use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Source\SomeInterface;
-use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Sourcet\SomeAbstractClass;
+use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Source\SomeAbstractClass;
 
 final class FinalInheritance extends SomeAbstractClass
 {
@@ -34,7 +34,7 @@ final class FinalInterfaceImplementation implements SomeInterface
 namespace Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Fixture;
 
 use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Source\SomeInterface;
-use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Sourcet\SomeAbstractClass;
+use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Source\SomeAbstractClass;
 
 final class FinalInheritance extends SomeAbstractClass
 {

rules-tests/DeadCode/Rector/FunctionLike/NarrowWideUnionReturnTypeRector/Fixture/skip_non_final_inheritance.php.inc

@@ -4,7 +4,7 @@
 namespace Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Fixture;
 
 use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Source\SomeInterface;
-use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Sourcet\SomeAbstractClass;
+use Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Source\SomeAbstractClass;
 
 class SkipInheritance extends SomeAbstractClass
 {

rules-tests/DeadCode/Rector/FunctionLike/NarrowWideUnionReturnTypeRector/Source/SomeAbstractClass.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Sourcet;
+namespace Rector\Tests\DeadCode\Rector\FunctionLike\NarrowWideUnionReturnTypeRector\Source;
 
 abstract class SomeAbstractClass
 {

rules-tests/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector/Source/ValueObject/Repository.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Source\ValueObject;
+namespace Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Source\ValueObject;
 
 final class Repository
 {

rules/DeadCode/NodeAnalyzer/PropertyWriteonlyAnalyzer.php

@@ -27,7 +27,7 @@ public function __construct(
 
     public function hasClassDynamicPropertyNames(Class_ $class): bool
     {
-        return (bool) $this->betterNodeFinder->findFirst($class, function (Node $node) : bool {
+        return (bool) $this->betterNodeFinder->findFirst($class, function (Node $node): bool {
             if ($node instanceof FuncCall && $this->nodeNameResolver->isName(
                 $node,
                 'get_object_vars'

src/Configuration/ConfigInitializer.php

@@ -43,7 +43,8 @@ public function createConfig(string $projectDirectory): void
             return;
         }
 
-        $mainConfigFile = $this->rectorConfigsResolver->provide()->getMainConfigFile();
+        $mainConfigFile = $this->rectorConfigsResolver->provide()
+            ->getMainConfigFile();
         if ($mainConfigFile !== null && file_exists($mainConfigFile)) {
             $this->symfonyStyle->warning(
                 'Register rules or sets in your "' . basename($mainConfigFile) . '" config'

structarmed.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+use Boundwize\StructArmed\Architecture;
+use Boundwize\StructArmed\Preset\Preset;
+use Boundwize\StructArmed\Preset\Presets\Psr4Preset;
+
+return Architecture::define()
+    ->skip([
+        Psr4Preset::CLASSES_MUST_MATCH_COMPOSER => [
+            // the namespace different is on purpose
+            __DIR__ . '/rules-tests/Renaming/Rector/Name/RenameClassRector',
+            __DIR__ . '/rules-tests/CodingStyle/Rector/Namespace_',
+
+            // no namespace on purpose
+            __DIR__ . '/rules-tests/Php70/Rector/ClassMethod/Php4ConstructorRector/Source/ParentClass.php',
+
+            // multi classes in one file on purpose
+            __DIR__ . '/rules-tests/Php70/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector/Source/Service.php',
+
+            // simulate under phpstan.phar
+            __DIR__ . '/rules-tests/Php71/Rector/FuncCall/RemoveExtraParametersRector/Source/phpstan.phar',
+        ],
+    ])
+    ->withPreset(Preset::PSR4());

tests/FileSystem/FilesFinder/SourceWithSuffix/OtherUnrelatedFile.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Tests\FileSystem\FilesFinder\SourceWithSuffix;
+
+final class OtherUnrelatedFile
+{
+}

tests/FileSystem/FilesFinder/SourceWithSuffix/SomeController.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace FileSystem\FilesFinder\SourceWithSuffix;
+namespace Rector\Tests\FileSystem\FilesFinder\SourceWithSuffix;
 
 final class SomeController
 {

tests/FileSystem/FilesFinder/SourceWithSuffix/SomeRepository.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace FileSystem\FilesFinder\SourceWithSuffix;
+namespace Rector\Tests\FileSystem\FilesFinder\SourceWithSuffix;
 
 final class SomeRepository
 {

tests/Issues/InlineTags/InlineTagsTest.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\Tests\Issues\InlineTagsTest;
+namespace Rector\Tests\Issues\InlineTags;
 
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;