Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector\Fixture;

readonly class SkipUsedByGetObjectVars
{
public function __construct(private string $foo)
{
}

public function toArray(): array
{
return get_object_vars($this);
}
}
14 changes: 2 additions & 12 deletions rules/DeadCode/NodeAnalyzer/PropertyWriteonlyAnalyzer.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,32 +13,22 @@
use PhpParser\Node\Expr\StaticPropertyFetch;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt\Class_;
use PHPStan\Type\ObjectType;
use Rector\NodeNameResolver\NodeNameResolver;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\NodeTypeResolver\NodeTypeResolver;
use Rector\PhpParser\Node\BetterNodeFinder;

final readonly class PropertyWriteonlyAnalyzer
{
public function __construct(
private BetterNodeFinder $betterNodeFinder,
private NodeTypeResolver $nodeTypeResolver,
private NodeNameResolver $nodeNameResolver
) {
}

public function hasClassDynamicPropertyNames(Class_ $class): bool
{
$isImplementsJsonSerializable = $this->nodeTypeResolver->isObjectType(
$class,
new ObjectType('JsonSerializable')
);

return (bool) $this->betterNodeFinder->findFirst($class, function (Node $node) use (
$isImplementsJsonSerializable
): bool {
if ($isImplementsJsonSerializable && $node instanceof FuncCall && $this->nodeNameResolver->isName(
return (bool) $this->betterNodeFinder->findFirst($class, function (Node $node) : bool {
if ($node instanceof FuncCall && $this->nodeNameResolver->isName(
$node,
'get_object_vars'
) && ! $node->isFirstClassCallable()) {
Expand Down
Loading