Skip to content

[dx] warn early about deprecated skipped rules, as not neccessary to skip anymore#7742

Merged
TomasVotruba merged 2 commits into
mainfrom
tv-skip-depre-warn
Dec 9, 2025
Merged

[dx] warn early about deprecated skipped rules, as not neccessary to skip anymore#7742
TomasVotruba merged 2 commits into
mainfrom
tv-skip-depre-warn

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Dec 9, 2025

Ref: rectorphp/rector#9543


Rector already warns about rules that are used, but deprecated. That way they can be removed/adjusted in time.

For the skip option we don't have such reporting yet, so it can lead to sudden removal.

return RectorConfig::configure()
->withSkip([
        \Rector\Php81\Rector\Array_\FirstClassCallableRector::class,
]);

This PR fixes that :)

Screenshot From 2025-12-09 11-46-51

@TomasVotruba TomasVotruba changed the title tv skip depre warn [dx] warn early about deprecated skipped rules, as not neccessary to skip anymore Dec 9, 2025
@TomasVotruba TomasVotruba merged commit ca6cf9c into main Dec 9, 2025
58 checks passed
@TomasVotruba TomasVotruba deleted the tv-skip-depre-warn branch December 9, 2025 10:53
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant