add PhpVersionConditionNodeVisitor#7709
Conversation
TomasVotruba
force-pushed
the
tv-version-check-attribute
branch
from
cf0a8a9 to
f7bcc84
Compare
| use Rector\NodeTypeResolver\Node\AttributeKey; | ||
| use Rector\PhpParser\NodeTraverser\SimpleNodeTraverser; | ||
|
|
||
| final class PhpVersionConditionNodeVisitor extends NodeVisitorAbstract implements DecoratingNodeVisitorInterface |
There was a problem hiding this comment.
instead of this, you might be interessted in $scope->getPhpVersion() which returns a version which can be narrowed by composer.json constraints and/or if(PHP_VERSION_ID > xy) check etc.
see also https://staabm.github.io/2024/11/14/phpstan-php-version-narrowing.html
There was a problem hiding this comment.
I'll give it a go today, thanks for heads-up 👌
There was a problem hiding this comment.
Just tested on the downgrade rule I've introduced this for: https://github.com/rectorphp/rector-downgrade-php/pull/349/files#diff-5f67d22ffde95a027219085ed3266b9ae5277dd85eecf7771c41881372cba9af
And it picks up local version (PHP 8.2), so it never downgrades to PHP 8.1. Not suitable for this kind of operation.
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
2 participants
No description provided.