[Transform] Use ContextAnalyzer->isLeftPartOfAssign() on ArrayDimFetchToMethodCallRector#7702
Closed
samsonasik wants to merge 1 commit into
Closed
[Transform] Use ContextAnalyzer->isLeftPartOfAssign() on ArrayDimFetchToMethodCallRector#7702samsonasik wants to merge 1 commit into
samsonasik wants to merge 1 commit into
Conversation
…hToMethodCallRector
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
I prefer direct attribute use over 5-line service. |
Member
Author
|
The service handle attribute other assign usage: by ref, not only assign by and op |
Member
|
I'd take a PR with an attribute + test case to verify. |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #7697 (review)
There is already service that handle it:
ContextAnalyzer->isLeftPartOfAssign()