Skip to content

Revert "[Experiment][Printer] Move AlwaysRememberedExpr tweak logic to separate service after a Match_ found"#7672

Merged
TomasVotruba merged 1 commit into
mainfrom
revert-7654-expr-add-virtual
Nov 27, 2025
Merged

Revert "[Experiment][Printer] Move AlwaysRememberedExpr tweak logic to separate service after a Match_ found"#7672
TomasVotruba merged 1 commit into
mainfrom
revert-7654-expr-add-virtual

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Nov 27, 2025

Reverts #7654

@samsonasik Seems this one has broken build. Reverting for now.
Can you test the full_build.sh before next iteration? So we know what the bug is.

Screenshot From 2025-11-27 12-12-43

@samsonasik
Copy link
Copy Markdown
Member

I tested locally, working ok:

 3254/3254 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] 1622 files have been changed by Rector                                                                            
                                                                                                                        
[NOTE] Starts

but that seems because of my local computer is good with 12 cores processor :), seems ok to revert and test :)

@TomasVotruba TomasVotruba merged commit 1d87f5a into main Nov 27, 2025
54 checks passed
@TomasVotruba TomasVotruba deleted the revert-7654-expr-add-virtual branch November 27, 2025 11:15
@TomasVotruba
Copy link
Copy Markdown
Member Author

I see :)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants