Skip to content

[Php81] Skip as Arg of non-native function call on FunctionLikeToFirstClassCallableRector#7592

Merged
samsonasik merged 4 commits into
mainfrom
skip-as-arg-of-non-native-function
Oct 27, 2025
Merged

[Php81] Skip as Arg of non-native function call on FunctionLikeToFirstClassCallableRector#7592
samsonasik merged 4 commits into
mainfrom
skip-as-arg-of-non-native-function

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Oct 27, 2025

When on method call, it can be anything defined in caller, this PR skip if it is as arg of non-native function call.

The skipped parts already in other fixtures, the updated fixture for demonstrate trailing comma :)

@samsonasik
Copy link
Copy Markdown
Member Author

@maks-oleksyuk this should cover most of the issue it have, it skip if it used as arg of non-native function call :)

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik enabled auto-merge (squash) October 27, 2025 15:49
@samsonasik samsonasik merged commit 0bbb4c7 into main Oct 27, 2025
53 checks passed
@samsonasik samsonasik deleted the skip-as-arg-of-non-native-function branch October 27, 2025 15:50
@maks-oleksyuk
Copy link
Copy Markdown

@maks-oleksyuk this should cover most of the issue it have, it skip if it used as arg of non-native function call :)

Yes, I checked it on my own case, and indeed, it no longer causes the error I described earlier. Thank you.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants