Skip to content

Pipe rule - adjustments#7579

Merged
TomasVotruba merged 2 commits into
mainfrom
tv-pipe-errate
Oct 25, 2025
Merged

Pipe rule - adjustments#7579
TomasVotruba merged 2 commits into
mainfrom
tv-pipe-errate

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

  • add more fixtures
  • [pipe] add custom printer to newline pipe always next line

Comment thread src/PhpParser/Printer/BetterStandardPrinter.php Outdated
Comment thread src/PhpParser/Printer/BetterStandardPrinter.php Outdated
@TomasVotruba TomasVotruba changed the title tv pipe errate Pipe rule - adjustments Oct 25, 2025
@TomasVotruba TomasVotruba merged commit 5cb3b9e into main Oct 25, 2025
53 checks passed
@TomasVotruba TomasVotruba deleted the tv-pipe-errate branch October 25, 2025 19:56
return $this->pInfixOp(
Pipe::class,
$node->left,
$this->nl . $this->resolveIndentSpaces() . '|> ',
Copy link
Copy Markdown
Member

@samsonasik samsonasik Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if resolveIndentSpaces() used, the normal "\n" should be used instead over $this->nl, I will create new PR for inside function/classmethod usage test

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants