[depre] Deprecate 3 configurable-only, never used closure param rules as too specific#7541
Merged
Conversation
TomasVotruba
changed the title
…ot used and pratical in core rules
…, requires configuration and never used
TomasVotruba
force-pushed
the
tv-cleanup
branch
2 times, most recently
from
d214170 to
862d777
Compare
TomasVotruba
changed the title
…tionRector as too specific and not useful for general community rules
TomasVotruba
force-pushed
the
tv-cleanup
branch
from
37e95b0 to
ea82e53
Compare
Member
|
/cc @peterfox FYI |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6258 and #5547
I'm going through some old rules and see if they're used. Goal is to push too specific rules down to local custom or external projects, to make Rector core leaner and more universal to typical user.
I could not find these 2 on Github, nor Rector Laravel:
Saying that, I'll deprecate these 2 and remove them. Just headsup 👍
If they're used, I recommend adding them to Laravel specific sets. It might be easier to add these types, without having exact
Applicationtype. I know Laravel uses lot of magic and types can be lost easily. But this rule would be still useful inServiceProvidercontext.