[Php81][CodingStyle] Skip callable param assign with signature multi params on FunctionLikeToFirstClassCallableRector

[samsonasik]

Fixes rectorphp/rector#9453

original: works: https://3v4l.org/SqOPO
changed: error https://3v4l.org/8kku6

Ref https://getrector.com/demo/371133f2-0c1c-4d0f-8e5c-958d89098e39

[samsonasik]

Fixed 🎉 /cc @calebdw

[calebdw]

@samsonasik, you should also test that this does convert to first class callable when both params are used:

function foo(mixed $datum, int|string|null $key) {}

(new SkipCallableParamAssignWithSignatureMultiParams())
-   ->withTransform(fn ($datum, $key) => foo($datum, $key))
+   ->withTransform(foo(...))
    ->run('  some data  ');

[samsonasik]

@calebdw I am going to skip for now :), this is already too complex to cover, the issue is not in the withTransform(), but on usage, as run() has default value, see original issue comment rectorphp/rector#9449 (comment)

[calebdw]

We should not care about the usage in run as long as the callable conforms to the signature that's specified on withTransform

[samsonasik]

I prefer to only check multi params when dealing with native function, otherwise, skip for now, as that become hard to review changed code.

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.