[Printer] Fixture crash on named argument usage on array_map() due to unpack arg flipped

[samsonasik]

Given the following code:

final class IncludeArrayMapNamed
{
    /**
     * @param int[] $items
     */
    public function run(array $items)
    {
        $result = array_map(array: $items, callback: fn ($item) => $item * 2);
    }
}

It currently got crash:

There was 1 failure:

1) Rector\Tests\TypeDeclaration\Rector\FuncCall\AddArrayFunctionClosureParamTypeRector\AddArrayFunctionClosureParamTypeRectorTest::test with data set #3 ('/Users/samsonasik/www/rector-...hp.inc')
assert($itemStartPos >= 0 && $itemEndPos >= 0 && $itemStartPos >= $pos)

/Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinterAbstract.php:842
/Users/samsonasik/www/rector-src/src/PhpParser/Printer/BetterStandardPrinter.php:281

Linked to php-parser getArg() method

• feat: add CallLike::getArg() method nikic/PHP-Parser#1089 (review)

[samsonasik]

/cc @calebdw

[samsonasik]

The issue seems on Printer itself, so nothing todo with getArg(),

[samsonasik]

If it know about the information on named argument and its unpacked on print, it seems the issue on Internal PHPStan printer...

[samsonasik]

Closing for now as seems unrelated with rector, possibly on phpstan/php-parser internal side, as without getArg() call, the crash still happen on printing.

[calebdw]

The issue seems on Printer itself, so nothing todo with getArg(),

That was my initial suspicion from looking at it

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.