Skip to content

feat: add greater and smaller support to StrlenZeroToIdenticalEmptyStringRector#7329

Merged
samsonasik merged 1 commit into
rectorphp:mainfrom
calebdw:calebdw/push-ptmvypouutot
Sep 25, 2025
Merged

feat: add greater and smaller support to StrlenZeroToIdenticalEmptyStringRector#7329
samsonasik merged 1 commit into
rectorphp:mainfrom
calebdw:calebdw/push-ptmvypouutot

Conversation

@calebdw
Copy link
Copy Markdown
Contributor

@calebdw calebdw commented Sep 25, 2025

Hello!

This closes rectorphp/rector#9385

Thanks!

CC: @simonschaufi

@simonschaufi
Copy link
Copy Markdown
Contributor

@calebdw thank you very much for taking care of this! I really appreciate!

@calebdw calebdw force-pushed the calebdw/push-ptmvypouutot branch from 601447a to f913335 Compare September 25, 2025 13:34
@calebdw calebdw force-pushed the calebdw/push-ptmvypouutot branch from f913335 to 230c0f1 Compare September 25, 2025 14:31
Copy link
Copy Markdown
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@samsonasik
Copy link
Copy Markdown
Member

Thank you @calebdw

@samsonasik samsonasik merged commit a92f244 into rectorphp:main Sep 25, 2025
50 checks passed
@calebdw calebdw deleted the calebdw/push-ptmvypouutot branch September 25, 2025 14:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Simplify strlen comparison

4 participants