Skip to content

[Php85] Add ChrArgModuloRector#7190

Merged
TomasVotruba merged 11 commits into
rectorphp:mainfrom
arshidkv12:php8.5_chr
Aug 31, 2025
Merged

[Php85] Add ChrArgModuloRector#7190
TomasVotruba merged 11 commits into
rectorphp:mainfrom
arshidkv12:php8.5_chr

Conversation

@arshidkv12
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr.php.inc Outdated
Comment thread rules/Php85/Rector/FuncCall/ChrArgModuloRector.php
Comment thread rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr_inbond.php.inc Outdated
Comment thread rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr_inbond.php.inc Outdated
Copy link
Copy Markdown
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my latest comment #7190 (comment)

Comment thread rules/Php85/Rector/FuncCall/ChrArgModuloRector.php
@arshidkv12
Copy link
Copy Markdown
Contributor Author

Please check it

Comment thread rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr.php.inc Outdated
Comment thread rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr_var.php.inc Outdated
@samsonasik
Copy link
Copy Markdown
Member

Looks good to me

@samsonasik samsonasik changed the title Wrap chr() argument with % 256 to avoid deprecated out-of-range integers [Php85] Add ChrArgModuloRector Aug 30, 2025
@TomasVotruba TomasVotruba merged commit ef73f11 into rectorphp:main Aug 31, 2025
49 checks passed
@TomasVotruba
Copy link
Copy Markdown
Member

Thank you, lets ship this 👍

arshidkv12 added a commit to arshidkv12/rector-src that referenced this pull request Sep 1, 2025
* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

---------

Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
arshidkv12 added a commit to arshidkv12/rector-src that referenced this pull request Sep 4, 2025
* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

---------

Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
arshidkv12 added a commit to arshidkv12/rector-src that referenced this pull request Sep 5, 2025
* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers

---------

Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants