Skip to content

offline pin:minor fix and icon change to fit properly #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rockhero1234 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −13
Open

offline pin:minor fix and icon change to fit properly #2528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/com/lagradost/cloudstream3/ui/download/DownloadButtonSetup.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ object DownloadButtonSetup {
uri = Uri.EMPTY,
id = it.id,
parentId = it.parentId,
name = it.name ?: act.getString(R.string.downloaded_file),
name = it.name
?: (act.getString(R.string.episode) + it.episode),
Copy link
Collaborator

@fire-light42 fire-light42 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains three fundamental issues.

  1. This may get triggered on a movie without a name.
  2. There is no spacing between episode and the number resulting in "Episode1"
  3. Episode number and season are already shown in the player? It would result in something like:
Episode 1 - 1920x1080
Breaking Bad "S1:E1" - Episode 1 ✓

season = it.season,
episode = it.episode,
headerName = parent.name,
Expand Down
20 changes: 12 additions & 8 deletions app/src/main/res/drawable/ic_offline_pin_24.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
<vector xmlns:android="http://schemas.android.com/apk/res/android" xmlns:aapt="http://schemas.android.com/aapt"
android:viewportWidth="960"
android:viewportHeight="960">
<path
android:pathData="M320,680h320v-80L320,600v80ZM438,560 L664,334 607,279 438,448 352,362 296,418 438,560ZM480,880q-83,0 -156,-31.5T197,763q-54,-54 -85.5,-127T80,480q0,-83 31.5,-156T197,197q54,-54 127,-85.5T480,80q83,0 156,31.5T763,197q54,54 85.5,127T880,480q0,83 -31.5,156T763,763q-54,54 -127,85.5T480,880ZM480,800q134,0 227,-93t93,-227q0,-134 -93,-227t-227,-93q-134,0 -227,93t-93,227q0,134 93,227t227,93ZM480,480Z"
android:fillColor="#e3e3e3"/>
</vector>
android:viewportHeight="960"
android:width="24dp"
android:height="24dp">
<group
android:translateX="-0"
android:translateY="960">
<path
android:pathData="M382 -320L155 -547l57 -57 170 170 366 -366 57 57 -423 423ZM200 -160v-80h560v80H200Z"
android:fillColor="@color/white" />
</group>
</vector>
8 changes: 4 additions & 4 deletions app/src/main/res/layout/player_custom_layout.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,12 @@
android:textColor="@color/white"
android:textStyle="bold"
android:visibility="visible"
tools:text="Hello world " />
tools:text="Hello world" />
<ImageView
android:id="@+id/offline_pin"
android:layout_width="16dp"
android:layout_height="16dp"
android:layout_marginStart="2dp"
android:layout_width="15dp"
android:layout_height="15dp"
android:layout_marginStart="1dp"
Copy link
Collaborator

@fire-light42 fire-light42 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the TV player not get changed too?

android:src="@drawable/ic_offline_pin_24"
android:visibility="gone"
tools:visibility="visible"
Expand Down