Skip to content

Bump up lib versions#148

Open
nyandika wants to merge 31 commits intoreactdeveloperske:prodfrom
nyandika:refactor/lib-updates
Open

Bump up lib versions#148
nyandika wants to merge 31 commits intoreactdeveloperske:prodfrom
nyandika:refactor/lib-updates

Conversation

@nyandika
Copy link
Contributor

Changes proposed

There have been recent vulnerabilities in the nextjs space. Taking this chance to bump up all package versions

Also added prod branch to github actions. This necessisated a rerun of prettier and linting hence the other numerous file changes

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

N/A

Note to reviewers

N/A

@vercel
Copy link

vercel bot commented Mar 29, 2025

@nyandika is attempting to deploy a commit to the React Developers Kenya Team on Vercel.

A member of the Team first needs to authorize it.

@orama254 orama254 self-requested a review April 1, 2025 14:11
Copy link
Member

@orama254 orama254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nyandika,

Thanks for this very critical pull request. Could you check up on the conflicts emerging?

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reactdevske-website Ready Ready Preview, Comment Feb 20, 2026 5:44am
reactdevske-website-vuvs Ready Ready Preview, Comment Feb 20, 2026 5:44am

@nyandika
Copy link
Contributor Author

nyandika commented Apr 1, 2025

Working on the failing tests. Will send an update

@nyandika
Copy link
Contributor Author

@orama254 Could you authorize this PR to deploy to vercel to get the pre-release view
I have fixed all failing tests

@orama254
Copy link
Member

@greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 16, 2026

Greptile Summary

This PR updates dependencies to address Next.js vulnerabilities, bumping Next.js from 12.3.1 to 16.1.6, React from 18.1.0 to 19.2.4, and modernizing the build toolchain. The prod branch was added to CI/CD workflows, which triggered linting and formatting updates across the codebase.

Key changes:

  • Updated Next.js, React, TypeScript, ESLint, Tailwind CSS, and Playwright to latest versions
  • Migrated to ESLint flat config (eslint.config.mjs) and updated Next.js config for deprecated APIs
  • Changed TypeScript JSX setting from preserve to react-jsx for React 19 compatibility
  • Removed unused imports and applied Prettier formatting across components
  • Updated GitHub Actions to Node.js 24.x and latest action versions

Critical issue:

  • tailwind.config.js has duplicate extend objects (lines 6 and 16) causing the first to be overridden, which will break custom animations and fonts

Confidence Score: 2/5

  • This PR has a critical configuration bug that will break Tailwind styling
  • While the dependency updates are necessary and well-intentioned, the duplicate extend object in tailwind.config.js will cause the custom animation and fontFamily configurations to be lost, potentially breaking the UI. The other changes are solid migrations to newer APIs.
  • Pay close attention to tailwind.config.js - it has duplicate extend objects that must be merged before merging this PR

Important Files Changed

Filename Overview
package.json Major version bumps for Next.js (12.3.1 → 16.1.6), React (18.1.0 → 19.2.4), and build tools; lint script simplified
tailwind.config.js Duplicate extend object at lines 6 and 16 - second will override first, losing initial animation/fontFamily config
eslint.config.mjs New ESLint flat config for Next.js with proper global ignores
next.config.js Updated image config to use remotePatterns (replacing deprecated domains), removed eslint.dirs
tsconfig.json Changed JSX from preserve to react-jsx for React 19 compatibility
.github/workflows/validate.yml Added prod branch trigger, updated Node.js 14.x → 24.x, updated actions to v6
.github/workflows/e2e.yml Added prod branch trigger, updated Node.js 18.x → 24.x, updated actions to v5/v6
src/components/HeroHeader/HeroHeader.tsx Added requestAnimationFrame for initial width setting; removed unused React import; cleanup added to useEffect

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Dependency Updates] --> B[Next.js 12.3.1 → 16.1.6]
    A --> C[React 18.1.0 → 19.2.4]
    A --> D[Tailwind 3.1.2 → 4.2.0]
    
    B --> E[New ESLint Flat Config]
    B --> F[Update next.config.js APIs]
    
    C --> G[Change TSConfig jsx to react-jsx]
    C --> H[Remove React imports]
    
    D --> I[Update PostCSS plugin]
    D --> J[Update tailwind.config.js]
    
    E --> K[Run Prettier/Linting]
    F --> K
    G --> K
    H --> K
    I --> K
    J --> K
    
    K --> L[38 Files Changed]
    
    J -.-> M[⚠️ Duplicate extend objects]
    
    style M fill:#ff6b6b,stroke:#c92a2a,color:#fff
    style A fill:#4dabf7,stroke:#1971c2,color:#fff
    style L fill:#51cf66,stroke:#2f9e44,color:#fff
Loading

Last reviewed commit: 41570df

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

33 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@nyandika
Copy link
Contributor Author

@orama254 fixed issues brought about by merge from prod

@orama254
Copy link
Member

@greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

38 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

orama254 and others added 2 commits February 20, 2026 14:03
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments