Skip to content

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Jan 27, 2026

Updated @rc-component/util dependency version from 1.2.1 to 1.7.0.

close ant-design/ant-design#56751

Summary by CodeRabbit

发布说明

  • 杂项
    • 更新了项目依赖版本,以获取最新的功能和改进。

✏️ Tip: You can customize this high-level summary in your review settings.

Updated @rc-component/util dependency version from 1.2.1 to 1.7.0.

close ant-design/ant-design#56751
@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
drawer Ready Ready Preview, Comment Jan 27, 2026 2:49am

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a crucial dependency update, specifically upgrading @rc-component/util to its latest stable version. This ensures the project benefits from the most recent features, performance improvements, and bug fixes provided by the updated utility package, enhancing overall stability and compatibility.

Highlights

  • Dependency Update: The @rc-component/util dependency has been updated from version 1.2.1 to 1.7.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

概览

更新了 package.json 中的 @rc-component/util 依赖版本,从 ^1.2.1 升级到 ^1.7.0,以支持 Drawer 组件所需的 useLockFocus 导出功能。

变更

文件组 / 文件 变更摘要
依赖更新
package.json
@rc-component/util 版本从 ^1.2.1^1.7.0,解决 Drawer 组件缺少 useLockFocus 导出的问题

代码审查工作量估计

🎯 1 (微小) | ⏱️ ~2 分钟

诗句

🐰 版本号小小升,
一点七零来相应,
useLockFocus 焦点锁,
Drawer 组件展笑容,
依赖更新解烦恼!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题清晰准确地总结了主要变化:更新@rc-component/util依赖版本。
Linked Issues check ✅ Passed 拉取请求将@rc-component/util从^1.2.1更新到^1.7.0,满足问题#56751要求的>=1.6.0版本要求。
Out of Scope Changes check ✅ Passed 拉取请求仅修改了package.json中@rc-component/util的版本号,与链接问题的范围完全一致,没有范围外的改动。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch afc163-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (925f9f5) to head (638ecf7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          205       205           
  Branches        75        75           
=========================================
  Hits           205       205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @rc-component/util dependency to fix a bug. I've suggested pinning the dependency to an exact version in package.json. This is a defensive measure because the codebase uses deep imports from this library (e.g., from /lib/ sub-paths), which makes it vulnerable to breaking changes even in minor releases. Pinning the version will ensure stability. As a more robust long-term solution, I recommend creating a follow-up task to refactor these deep imports to use the package's public API, if available.

"@rc-component/motion": "^1.1.4",
"@rc-component/portal": "^2.1.3",
"@rc-component/util": "^1.2.1",
"@rc-component/util": "^1.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Given that the project relies on deep imports from @rc-component/util (e.g., .../lib/warning), which are not guaranteed to be stable between versions, it's safer to pin this dependency to an exact version. This will prevent automatic minor updates from potentially breaking the build if the internal structure of the library changes. I suggest removing the caret (^) to lock the version.

Suggested change
"@rc-component/util": "^1.7.0",
"@rc-component/util": "1.7.0",

@afc163 afc163 merged commit d1d71cd into master Jan 27, 2026
13 checks passed
@afc163 afc163 deleted the afc163-patch-1 branch January 27, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export 'useLockFocus' (imported as 'useLockFocus') was not found in '@rc-component/util/es/Dom/focus'

2 participants