Replace toast with alert dialog upon export fail#70
Open
hugmouse wants to merge 1 commit intoranfdev:mainfrom
Open
Replace toast with alert dialog upon export fail#70hugmouse wants to merge 1 commit intoranfdev:mainfrom
hugmouse wants to merge 1 commit intoranfdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I was having some trouble understanding why the application export was failing due to truncated text in the toast. I thought maybe we should replace it with an
adw::AlertDialogsince there is more space for text (and overall just context around the error)That being said, having two dialog windows on top of each other feels a bit odd. Let me know what you think.
And also please check the code itself, I'm not so familiar either with Rust or GTK4, but wanted to contribute a little.
Before
After