Disable msvc warnings in source files#1111
Draft
bnoordhuis wants to merge 2 commits intoquickjs-ng:masterfrom
Draft
Disable msvc warnings in source files#1111bnoordhuis wants to merge 2 commits intoquickjs-ng:masterfrom
bnoordhuis wants to merge 2 commits intoquickjs-ng:masterfrom
Conversation
Contributor
Author
|
As I expected, this would need to be applied to other source files as well. Duplicating that is kind of meh although I guess it's manageable, it won't change often. I don't know if it would work when broken out to a separate header... and I also don't really want to do that, too much hassle.
Plenty of warnings from MS's own headers 🤦 |
...instead of from the cmake build file.
saghul
approved these changes
Jul 28, 2025
Contributor
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
Neat trick with the include 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...instead of from the cmake build file.