Skip to content

refactor: allow table details empty state with table selection#546

Open
emrberk wants to merge 5 commits intomainfrom
refactor/table-details-empty-state
Open

refactor: allow table details empty state with table selection#546
emrberk wants to merge 5 commits intomainfrom
refactor/table-details-empty-state

Conversation

@emrberk
Copy link
Collaborator

@emrberk emrberk commented Mar 26, 2026

  • Adds a table selector to table details drawer header if there is no table details history
  • Uses the same selector as metrics table selector
  • Styling updates for metrics header (table name, title, actions)
  • Layout updates to metrics dashboard
Screenshot 2026-03-26 at 10 17 39

@emrberk emrberk requested review from javier and nwoolmer March 26, 2026 07:19
Copy link

@javier javier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Works well, but I just discovered an issue that was already broken, just we didn't notice. Regular views don't appear on the details tab and cannot be selected, but they still have the "show details" option on hover on the left pane. I think the ideal would be that regular views would have details, but not monitoring tab, so the table creation details could still be seen. But not super strong feelings if we decide not to show details, but right now it is broken

javier
javier previously approved these changes Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants