refactor: allow table details empty state with table selection#546
Open
refactor: allow table details empty state with table selection#546
Conversation
Collaborator
emrberk
commented
Mar 26, 2026
- Adds a table selector to table details drawer header if there is no table details history
- Uses the same selector as metrics table selector
- Styling updates for metrics header (table name, title, actions)
- Layout updates to metrics dashboard
javier
requested changes
Mar 26, 2026
javier
left a comment
There was a problem hiding this comment.
Very cool. Works well, but I just discovered an issue that was already broken, just we didn't notice. Regular views don't appear on the details tab and cannot be selected, but they still have the "show details" option on hover on the left pane. I think the ideal would be that regular views would have details, but not monitoring tab, so the table creation details could still be seen. But not super strong feelings if we decide not to show details, but right now it is broken
javier
previously approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.