Conversation
- parse_entry_header: skip name:desc split when name would be empty (e.g. RST-style ':param foo:' lines now fall through to bare-name fallback) - required_token: match zero-length (missing) tokens so it only panics when the token kind is absent from children entirely - Add regression test: test_rst_style_param_in_args_no_panic
When a token is expected by grammar but absent from source, emit a zero-length (missing) placeholder token so callers can distinguish 'expected but missing' from 'not applicable' via find_missing(). Changes follow the same convention already used in build_arg_node (Google parser): - build_parameter_node: TYPE placeholder when colon present, type absent - build_returns_node: RETURN_TYPE placeholder when colon present, type absent - build_yields_node: RETURN_TYPE placeholder when colon present, type absent - build_exception_node: DESCRIPTION placeholder when colon present, desc absent - build_warning_node: DESCRIPTION placeholder when colon present, desc absent - build_see_also_node: DESCRIPTION placeholder when colon present, desc absent - build_attribute_node: TYPE placeholder when colon present, type absent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.