Open
Conversation
Collaborator
|
LGTM Any down sides to adding this? Additional memory perhaps? |
Author
The only downside is additional memory for duplicating faces when this flag is active - face triangle indices will be stored in two places: Material.faces (newly added in this PR) and Mesh.faces (original code). The latter is just the combination of all Material.faces. |
|
Any progress, pls? If a mesh contains multiple materials, we need to group the faces into materials. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior is only active when
collect_faces==True. This flag indicates that the user is interested in playing with faces at the cost of additional memory. This change allows people to have the option to operate on faces that has a specific material. I definitely need this feature for my own project. Pushing this change in case other people may find it useful.