Skip to content

Fix quantized_w8a32_conv1d fusion and operator#17290

Open
ethansfng wants to merge 1 commit intopytorch:mainfrom
ethansfng:export-D92565258
Open

Fix quantized_w8a32_conv1d fusion and operator#17290
ethansfng wants to merge 1 commit intopytorch:mainfrom
ethansfng:export-D92565258

Conversation

@ethansfng
Copy link
Contributor

Summary:

  1. Python fusion pass (fusion_pass.py): The permute nodes created in
    get_args_and_kwargs_mixed_w8a32_conv were missing val metadata, causing
    SpecViolationError during ExportedProgram validation. Added val computation
    using fake_mode, matching the pattern used by AddmmPattern.

  2. C++ operators (generic + HiFi): cnn_step was called once with wrong
    dimensions (input length instead of kernel_size for d1), only producing
    out_channels values instead of the full output. Fixed to loop over output
    time steps, calling cnn_step per position with correct kernel_size, then
    scattering to NCL output layout.

Differential Revision: D92565258

Summary:
1. Python fusion pass (fusion_pass.py): The permute nodes created in
   get_args_and_kwargs_mixed_w8a32_conv were missing val metadata, causing
   SpecViolationError during ExportedProgram validation. Added val computation
   using fake_mode, matching the pattern used by AddmmPattern.

2. C++ operators (generic + HiFi): cnn_step was called once with wrong
   dimensions (input length instead of kernel_size for d1), only producing
   out_channels values instead of the full output. Fixed to loop over output
   time steps, calling cnn_step per position with correct kernel_size, then
   scattering to NCL output layout.

Differential Revision: D92565258
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17290

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 354a924 with merge base 7823792 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Feb 7, 2026

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92565258.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2026
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant