Skip to content

Cortex-M quantizer: Use is_int8_activations helper in remaining checkers#17282

Open
psiddh wants to merge 1 commit intomainfrom
refactor_comp
Open

Cortex-M quantizer: Use is_int8_activations helper in remaining checkers#17282
psiddh wants to merge 1 commit intomainfrom
refactor_comp

Conversation

@psiddh
Copy link
Contributor

@psiddh psiddh commented Feb 6, 2026

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17282

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs, 2 Unrelated Failures

As of commit aadfb88 with merge base 02fe862 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2026
@psiddh psiddh marked this pull request as ready for review February 6, 2026 18:36
Copilot AI review requested due to automatic review settings February 6, 2026 18:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Cortex-M quantizer pattern checkers to consistently use the shared is_int8_activations helper when validating activation dtypes, reducing duplicated logic in quantization-config checks.

Changes:

  • Replaced inline int8 dtype checks in CortexMAddMulCheck.check_quantization_config with cls.is_int8_activations(...).
  • Replaced inline int8 dtype checks in CortexMLinearCheck.check_quantization_config with cls.is_int8_activations(...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant