Arm backend: Improve noop handling#17280
Open
AdrianLundell wants to merge 2 commits intopytorch:mainfrom
Open
Conversation
- Removes the identity node_visitor in favour of handling all noops in the remove_noop_pass - Adds detach_copy to the partitioner is_noop check to avoid partitioning graphs with single detach_copy ops - Make noop check functions in the partitioner private and remove public documentation. Instead handle alias_copy similar to other noops Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I018f4959865eae29b6842b88269e6be5b208509a
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17280
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New FailuresAs of commit d0be717 with merge base 02fe862 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…tream/change-1194036 Change-Id: I95cdf44749557dc88479460856aa21317712413e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead handle alias_copy similar to other noops
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai