Skip to content

Arm backend: Improve noop handling#17280

Open
AdrianLundell wants to merge 2 commits intopytorch:mainfrom
AdrianLundell:change-1194036
Open

Arm backend: Improve noop handling#17280
AdrianLundell wants to merge 2 commits intopytorch:mainfrom
AdrianLundell:change-1194036

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Feb 6, 2026

  • Removes the identity node_visitor in favour of handling all noops in the remove_noop_pass
  • Adds detach_copy to the partitioner is_noop check to avoid partitioning graphs with single detach_copy ops
  • Make noop check functions in the partitioner private and remove public documentation.

Instead handle alias_copy similar to other noops

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

- Removes the identity node_visitor in favour of handling
  all noops in the remove_noop_pass
- Adds detach_copy to the partitioner is_noop check to avoid
  partitioning graphs with single detach_copy ops
- Make noop check functions in the partitioner private and
  remove public documentation.

Instead handle alias_copy similar to other noops

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: I018f4959865eae29b6842b88269e6be5b208509a
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Feb 6, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17280

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit d0be717 with merge base 02fe862 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2026
…tream/change-1194036

Change-Id: I95cdf44749557dc88479460856aa21317712413e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant