Filter viable/strict failure report to only show required workflows#17250
Filter viable/strict failure report to only show required workflows#17250mergennachin wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17250
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 4 Unrelated FailuresAs of commit 5d65b43 with merge base d9488fb ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR filters the viable/strict failure report to only show workflows that are actually required for viable/strict updates, eliminating self-referential noise from the "Update viable/strict" workflow itself appearing in failure summaries.
Changes:
- Introduced a
REQUIRED_PATTERNvariable to match required workflows (pull, lint, trunk, Build documentation, Apple) - Applied case-insensitive pattern filtering to three workflow query locations: commit-specific failures, recent main branch failures, and 24-hour summary statistics
- Added explanatory comments documenting the filtering logic and case-insensitive matching behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The failure summary was showing all failed workflows, including "Update viable/strict" itself, which created self-referential noise. Changes: - Filter to only show workflows matching the `requires` patterns (pull, lint, trunk, Build documentation, Apple) - Use exact matching with anchors (^pattern$) to prevent substring matches - Use case-insensitive matching since workflow names may differ in case - Show up to 5 failed jobs per commit, joined with <br> in one table row - Add "(up to 5 jobs)" to the header for clarity
21a0c88 to
5d65b43
Compare
Here's the current summary: https://github.com/pytorch/executorch/actions/runs/21720882169/
Filter viable/strict failure report to only show required workflows
The failure summary was showing all failed workflows, including
"Update viable/strict" itself, which created self-referential noise.
Changes:
requirespatterns(pull, lint, trunk, Build documentation, Apple)
in one table row