Skip to content

Filter viable/strict failure report to only show required workflows#17250

Open
mergennachin wants to merge 1 commit intomainfrom
fix_viable_strict
Open

Filter viable/strict failure report to only show required workflows#17250
mergennachin wants to merge 1 commit intomainfrom
fix_viable_strict

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Feb 5, 2026

Here's the current summary: https://github.com/pytorch/executorch/actions/runs/21720882169/

Filter viable/strict failure report to only show required workflows

The failure summary was showing all failed workflows, including
"Update viable/strict" itself, which created self-referential noise.

Changes:

  • Filter to only show workflows matching the requires patterns
    (pull, lint, trunk, Build documentation, Apple)
  • Use exact matching with anchors (^pattern$) to prevent substring matches
  • Use case-insensitive matching since workflow names may differ in case
  • Show up to 5 failed jobs per commit, joined with
    in one table row
  • Add "(up to 5 jobs)" to the header for clarity

Copilot AI review requested due to automatic review settings February 5, 2026 17:43
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17250

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 4 Unrelated Failures

As of commit 5d65b43 with merge base d9488fb (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2026
@mergennachin mergennachin requested a review from SS-JIA February 5, 2026 17:43
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR filters the viable/strict failure report to only show workflows that are actually required for viable/strict updates, eliminating self-referential noise from the "Update viable/strict" workflow itself appearing in failure summaries.

Changes:

  • Introduced a REQUIRED_PATTERN variable to match required workflows (pull, lint, trunk, Build documentation, Apple)
  • Applied case-insensitive pattern filtering to three workflow query locations: commit-specific failures, recent main branch failures, and 24-hour summary statistics
  • Added explanatory comments documenting the filtering logic and case-insensitive matching behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The failure summary was showing all failed workflows, including
"Update viable/strict" itself, which created self-referential noise.

Changes:
- Filter to only show workflows matching the `requires` patterns
  (pull, lint, trunk, Build documentation, Apple)
- Use exact matching with anchors (^pattern$) to prevent substring matches
- Use case-insensitive matching since workflow names may differ in case
- Show up to 5 failed jobs per commit, joined with <br> in one table row
- Add "(up to 5 jobs)" to the header for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants