Skip to content

[wip] Introduce MultimethodLoraConfig#17230

Open
lucylq wants to merge 2 commits intogh/lucylq/133/basefrom
gh/lucylq/133/head
Open

[wip] Introduce MultimethodLoraConfig#17230
lucylq wants to merge 2 commits intogh/lucylq/133/basefrom
gh/lucylq/133/head

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Feb 5, 2026

Differential Revision: [D92315627](https://our.internmc.facebook.com/intern/diff/D92315627/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17230

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit c918989 with merge base eac0673 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq changed the title Introduce MultimethodLoraConfig [wip] Introduce MultimethodLoraConfig Feb 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces MultimethodLoraConfig, a new configuration class that enables exporting multiple methods (e.g., base model and LoRA variants) to a single .pte file. This is part of a larger stack adding multimethod support to the LLM export pipeline.

Changes:

  • Added Dict to typing imports to support the new configuration structure
  • Introduced MultimethodLoraConfig class with a dictionary mapping method names to optional LoRA configurations
  • Integrated MultimethodLoraConfig as a new field in the LlmConfig class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant