[pexpect] Accept dict for env parameter, not just os.environ
#15270
+12
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
envparameter in pexpect was typed asos._Environ[str], which only acceptsos.environdirectly. This broke common patterns like passing{"PATH": "/usr/bin"}oros.environ.copy(). The fix changes the type toMapping[str, str](orsubprocess._ENVforPopenSpawn) to match what the code actually accepts.PopenSpawnpasses env tosubprocess.Popen, whilespawn/pxssh/runpass it to bothutils.which()(which doesenv.get('PATH')and requires string keys/values) andptyprocess. All of these work fine with anydict-like mapping, not just the specialos.environobject.Closes #14915