Fix parallel worker crash on syntax error#21202
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Apr 10, 2026
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
Author
|
@JukkaL since the fix is trivial, I am not waiting for review to speed up process, please let me know still if you have any comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21195
Fix is straightforward, and also makes tag reading convention similar to regular cache (i.e. caller reads the tag). @JukkaL when this is merged, I am going to rebase splitting PR to apply the same fix there.
Note that a cmdline (i.e. full) test is required for this, since this is not a crash from the point of view of the test harness, the workers simply dump tracebacks to stderr when they crash, while coordinator exits normally.
Btw, as I mentioned in original PR #20280, at some point I am going to redirect workers' stdout/stderr to a log file, similar to how we do it with the daemon. This would also fix this issue, but I prefer that workers always exit normally when possible, i.e. only genuinely unexpected conditions should crash the workers.