Skip to content

Fix parallel worker crash on syntax error#21202

Merged
ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi:fix-syntax-parallel
Apr 10, 2026
Merged

Fix parallel worker crash on syntax error#21202
ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi:fix-syntax-parallel

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

Fixes #21195

Fix is straightforward, and also makes tag reading convention similar to regular cache (i.e. caller reads the tag). @JukkaL when this is merged, I am going to rebase splitting PR to apply the same fix there.

Note that a cmdline (i.e. full) test is required for this, since this is not a crash from the point of view of the test harness, the workers simply dump tracebacks to stderr when they crash, while coordinator exits normally.

Btw, as I mentioned in original PR #20280, at some point I am going to redirect workers' stdout/stderr to a log file, similar to how we do it with the daemon. This would also fix this issue, but I prefer that workers always exit normally when possible, i.e. only genuinely unexpected conditions should crash the workers.

@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi
Copy link
Copy Markdown
Member Author

@JukkaL since the fix is trivial, I am not waiting for review to speed up process, please let me know still if you have any comments.

@ilevkivskyi ilevkivskyi merged commit fed3593 into python:master Apr 10, 2026
24 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-syntax-parallel branch April 10, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax error triggers crash in parallel mode

1 participant