Skip to content

Optimize load_graph to avoid O(n**2) 'not ready' tracking #20786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 1 commit into from
Feb 12, 2026
Merged

Optimize load_graph to avoid O(n**2) 'not ready' tracking #20786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mypy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3957,12 +3957,12 @@ def process_graph(graph: Graph, manager: BuildManager) -> None:

# Prime the ready list with leaf SCCs (that have no dependencies).
ready = []
not_ready = []
not_ready = set()
for scc in sccs:
if not scc.deps:
ready.append(scc)
else:
not_ready.append(scc)
not_ready.add(scc)

still_working = False
while ready or not_ready or still_working:
Expand Down