[mypyc] Add big endian read/write functions to librt.strings #20772
+660
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
p-sawicki
approved these changes
Feb 9, 2026
JukkaL
added a commit
that referenced
this pull request
Feb 10, 2026
Support both 32-bit and 64-bit float formats, and also support little endian and big endian (e.g. `write_f64_le`). I think the read/write function feature set now covers all the essential functionality. We can consider adding `u8` variants in the future, though they can already be supported using just `append` and get item. Follow-up to #20772. I used coding agent assist significantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty straightforward -- add big endian variants of existing functions.
Follow-up to #20757.
I'll add float read/write functions in a follow-up PR.
Also restructure primitive definitions to have more consistent order.
I used coding agent assist to generate the repetitive parts and to refactor the code and tests.