Expanded subcommand management API.#1663
Conversation
kmvanbrunt
commented
May 14, 2026
- Detaching a subcommand returns metadata for easily reattaching later
- Added ability to remove all subcommands of a given command
1. Detaching a subcommand returns metadata for easily reattaching later 2. Added ability to remove all subcommands of a given command
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
- Coverage 99.55% 99.53% -0.02%
==========================================
Files 22 22
Lines 4889 4934 +45
==========================================
+ Hits 4867 4911 +44
- Misses 22 23 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
left a comment
There was a problem hiding this comment.
The test_proc_reader_terminate test is failing due to a timeout specifically for Window and Python 3.10. It may be a one-off fluke or it might not be.
I don't think I'd worry about it for this PR unless you have insight into what might be causing it.
We talked earlier today about dropping support for Python 3.10 in the upcoming 4.0.0 release and I am fully in support of that. I think we should do that in a separate PR.