[rich_utils] added Paragraph Help Formatters based on rich_argparse classes#1656
Closed
neoniobium wants to merge 3 commits intopython-cmd2:mainfrom
Closed
[rich_utils] added Paragraph Help Formatters based on rich_argparse classes#1656neoniobium wants to merge 3 commits intopython-cmd2:mainfrom
neoniobium wants to merge 3 commits intopython-cmd2:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
==========================================
+ Coverage 99.50% 99.52% +0.02%
==========================================
Files 21 21
Lines 4813 4816 +3
==========================================
+ Hits 4789 4793 +4
+ Misses 24 23 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Thanks for the PR, but I purposely don't include the non-standard help formatters from class ParagraphCmd2HelpFormatter(
ParagraphRichHelpFormatter,
Cmd2HelpFormatter,
): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added two new argparse Formatter classes based on the equivalent classes in the
rich_argparsepackage.Since the
ExtendedParagraphRichHelpFormatterwas added inrich_argparseversion1.8.0also bump the minimum version to1.8.0.Reference: