Skip to content

Fix collection for remote UPath nodes#820

Merged
tobiasraabe merged 5 commits intomainfrom
codex/fix-remote-upath-collection
Mar 22, 2026
Merged

Fix collection for remote UPath nodes#820
tobiasraabe merged 5 commits intomainfrom
codex/fix-remote-upath-collection

Conversation

@tobiasraabe
Copy link
Member

Summary

  • preserve full URIs for non-local UPath values instead of routing them through local path shortening
  • exclude non-local path nodes from the collect --nodes common-ancestor calculation
  • add regression coverage for remote PickleNode collection and node display

Repro

A task or catalog entry with PickleNode(path=UPath("s3://bucket/in.pkl")) and an empty name would route through local path handling during collection. That produced incorrect names such as s3:/bucket/in.pkl, and collect --nodes could fail when remote UPaths were mixed into the common-ancestor calculation.

Validation

  • uv run --python 3.14 --group test pytest tests/test_collect.py tests/test_collect_command.py tests/test_path.py
  • uv run --with ruff ruff check src/_pytask/path.py src/_pytask/collect_command.py tests/test_collect.py tests/test_collect_command.py tests/test_path.py
  • uv run --group typing --group test --isolated ty check src/_pytask/path.py src/_pytask/collect_command.py tests/test_collect.py tests/test_collect_command.py tests/test_path.py

@tobiasraabe tobiasraabe enabled auto-merge March 22, 2026 14:58
@tobiasraabe tobiasraabe added this pull request to the merge queue Mar 22, 2026
Merged via the queue into main with commit deed356 Mar 22, 2026
21 checks passed
@tobiasraabe tobiasraabe deleted the codex/fix-remote-upath-collection branch March 22, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant