Conversation
… into balugaq/potion-altar
…q/potion-altar
Seggan
left a comment
Seggan
left a comment
There was a problem hiding this comment.
I love the concept and the execution in the multiblock. Maybe add some particles or smth specifically for when it's going through the crafting cycle?
Co-authored-by: Daniel Karnaukh <seggan21@gmail.com>
…PotionAltar.java Co-authored-by: Daniel Karnaukh <seggan21@gmail.com>
…PotionAltar.java Co-authored-by: Daniel Karnaukh <seggan21@gmail.com>
QQ20260411-231731.mp4Also tested recipe-recovering |
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
Love the idea and the visual implementation is really really nice
|
Also forgot to mention, the catalyst are quite expensive to REALLY expensive for being single-use items. I would make them significantly cheaper |
Now simplified more I think: replace |
|
tested |
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
I do think the ascendant ember recipe is still too expensive to be worth it, remove the shimmer dust 3 from the recipe? shimmer dust 3 is very annoying to make.
The potion altar should have its direction set with setMultiblockDirectional and should also be a RebarDirectionalBlock
Consider this approved once that is done
(Also I think it would be better if the potion altar catalysts used recipes and recipe processor instead but not going to request changes on that as the processor stuff is getting reworked soon anyway)
|
Done. by the way, a problem related to RebarTranslator: |
Just make an issue for it, I'll get to it at some point |
| * This method is called when an item is inserted into the pedestal. It can be used to check if the item is | ||
| * allowed to be inserted. | ||
| * | ||
| * @return true if the item is illegal, false otherwise |
There was a problem hiding this comment.
| * @return true if the item is illegal, false otherwise | |
| * @return true if the item can be inserted into the pedestal, false otherwise |
Clearer wording
| /** | ||
| * `apply-success-rate` (double type) is required to check the success rate of the catalyst. | ||
| * @see RebarItem#getSettings() | ||
| */ | ||
| @NotNull | ||
| Config getSettings(); |
There was a problem hiding this comment.
I'd do a double getApplicationSuccessRate() instead
| too-many-effects: "<red>You have to put 2 potions with less than %max_effect_types% different effects" | ||
| fused-potion-name: "<green>Fused Potion" | ||
| failed-apply-catalyst: "<red>Failed to apply catalyst" | ||
| cannot-apply-catalyst: "<red>Cannot to apply catalyst" |
There was a problem hiding this comment.
| cannot-apply-catalyst: "<red>Cannot to apply catalyst" | |
| cannot-apply-catalyst: "<red>Cannot apply catalyst" |
3 participants
No description provided.