Abstract Microscope base class and introduce ThermoDigitalTwin#39
Open
DomPTech wants to merge 1 commit intopycroscopy:PyTangofrom
Open
Abstract Microscope base class and introduce ThermoDigitalTwin#39DomPTech wants to merge 1 commit intopycroscopy:PyTangofrom
Microscope base class and introduce ThermoDigitalTwin#39DomPTech wants to merge 1 commit intopycroscopy:PyTangofrom
Conversation
…in` for simulated operations (along with tests and notebook example); removed pyside from pyproject
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a digital twin implementation for the ThermoMicroscope for simulated image acquisition and tests. The main changes include the addition of the
ThermoDigitalTwindevice, updates to the abstract base class pattern for Tango devices, and refactoring of test infrastructure to use the new digital twin.Digital Twin:
ThermoDigitalTwinMicroscope inasyncroscopy/ThermoDigitalTwin.pytests/test_digital_twin.pynotebooks/Digital_Twin.ipynbtests/conftest.pyto useThermoDigitalTwinfor all simulated microscope testsAbstract Base Class:
Microscopeinasyncroscopy/Microscope.pyto use a combined metaclass (CombinedMeta) that merges Tango'sDeviceMetaand Python'sABCMeta(hopefully this fixes the issue that we discussed with the abstract methods)Microscopeto proper@abstractmethodsOther:
pyside6dependency frompyproject.tomlso it can run on the supercomputer