Skip to content

fix: リノートをリノートする時は元投稿を参照する#1471

Merged
laminne merged 10 commits intomainfrom
fix/1465-renote-reaction-renote-logic
Mar 14, 2026
Merged

fix: リノートをリノートする時は元投稿を参照する#1471
laminne merged 10 commits intomainfrom
fix/1465-renote-reaction-renote-logic

Conversation

@laminne
Copy link
Copy Markdown
Member

@laminne laminne commented Mar 4, 2026

related #1465

What does this PR do?

  • リノートをリノートする時はリノート対象が参照している投稿を参照するようにしました
    • (日本語が難しい, 詳しくはIssueを見てください)

Additional information

  • NoteモデルにisRenote/isQuoteメソッドを追加
    • 同時にrenote/quoteメソッドも追加しています

Checklist

  • Includes API changes
    • Includes braking changes
      • If you change any endpoint schema, you must update the OpenAPI schema definitions (use pnpm build:api).
  • Includes database schema changes

@laminne laminne self-assigned this Mar 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.29%. Comparing base (b9c42c7) to head (836cf61).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/notes/service/renote.ts 92.30% 3 Missing ⚠️
pkg/notes/model/note.ts 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
+ Coverage   41.80%   42.29%   +0.49%     
==========================================
  Files         143      143              
  Lines        5411     5454      +43     
  Branches      920      935      +15     
==========================================
+ Hits         2262     2307      +45     
+ Misses       3149     3147       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne laminne force-pushed the fix/1465-renote-reaction-renote-logic branch from e9d73ec to dc1a4ae Compare March 12, 2026 14:32
@laminne laminne marked this pull request as ready for review March 13, 2026 11:24
@laminne laminne enabled auto-merge March 13, 2026 11:41
@laminne laminne requested a review from MikuroXina March 13, 2026 11:41
Comment thread pkg/notes/service/renote.ts Outdated
@laminne laminne requested a review from MikuroXina March 14, 2026 02:57
@laminne laminne added this pull request to the merge queue Mar 14, 2026
Merged via the queue into main with commit 0f07a4e Mar 14, 2026
5 checks passed
@laminne laminne deleted the fix/1465-renote-reaction-renote-logic branch March 14, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(model): リノートに対するリアクション・リノートの挙動を整理する

2 participants