Skip to content

[hardware] fix integer reduction commit logic#439

Merged
Navaneeth-KunhiPurayil merged 1 commit intomainfrom
fix/reductions
Mar 13, 2026
Merged

[hardware] fix integer reduction commit logic#439
Navaneeth-KunhiPurayil merged 1 commit intomainfrom
fix/reductions

Conversation

@Navaneeth-KunhiPurayil
Copy link
Collaborator

@Navaneeth-KunhiPurayil Navaneeth-KunhiPurayil commented Mar 10, 2026

This PR fixes an issue observed when we have back-to-back reduction operations. lane0 goes to the SIMD_REDUCTION state and set's result_queue_valid_d to 1'b1 and sets commit_cnt_d = '0. This creates a problem if we have back-to-back reductions, since the alu_state_d switches from SIMD_REDUCTION to INTRA_LANE_REDUCTION without staying in SIMD_REDUCTION or NO_REDUCTION state for one more cycle for the commit to happen.

Now, the commit_cnt_d is set to '0 only after a successful commit to the VRF.

Changelog

Fixed

  • Commit logic after SIMD_REDUCTION for lane0

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Please check our contributing guidelines before opening a Pull Request.

@hopang-0221
Copy link

Hi navaneeth, this fix looks good to me. Thanks!

@Navaneeth-KunhiPurayil Navaneeth-KunhiPurayil merged commit 4f876b5 into main Mar 13, 2026
205 checks passed
@Navaneeth-KunhiPurayil Navaneeth-KunhiPurayil deleted the fix/reductions branch March 13, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants