Open
Conversation
Author
|
Hmm, 302 response for |
Make the dependency on flasgger optional. The dependency has been added relatively recently (i.e. before the original package was abandoned but after its last release), and it is only used to provide a more dynamic landing page. This is unnecessary for use of httpbin for testing, and it introduces an indirect dependency on Rust that is problematic. With this change, flasgger is no longer installed by default. It can be enabled via "[flasgger]" extra. When flasgger is not available, httpbin redirects to the "legacy" index page.
mgorny
added a commit
to mgorny/vcrpy
that referenced
this pull request
Feb 16, 2024
Make the tests slightly more flexible to match both the flasgger-based and legacy httpbin index. This is needed for compatibility with psf/httpbin#44 when flasgger is not installed (e.g. on architectures that are not supported by Rust).
|
Seems to be a duplicate of #32 . But either way, would be great to see flasgger removed as dependency. |
deronnax
pushed a commit
to deronnax/vcrpy
that referenced
this pull request
Dec 8, 2025
Make the tests slightly more flexible to match both the flasgger-based and legacy httpbin index. This is needed for compatibility with psf/httpbin#44 when flasgger is not installed (e.g. on architectures that are not supported by Rust).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the dependency on flasgger optional. The dependency has been added relatively recently (i.e. before the original package was abandoned but after its last release), and it is only used to provide a more dynamic landing page. This is unnecessary for use of httpbin for testing, and it introduces an indirect dependency on Rust that is problematic.
With this change, flasgger is no longer installed by default. It can be enabled via "[flasgger]" extra. When flasgger is not available, httpbin redirects to the "legacy" index page.