feat(macOS): Add macOS support to fetchpkg#5
Open
br3akzero wants to merge 3 commits intops5-payload-dev:masterfrom
Open
feat(macOS): Add macOS support to fetchpkg#5br3akzero wants to merge 3 commits intops5-payload-dev:masterfrom
br3akzero wants to merge 3 commits intops5-payload-dev:masterfrom
Conversation
macOS declares basename() in <string.h> with a conflicting return type, causing a compile error. Rename the static function to avoid the conflict.
Uses Homebrew's curl include/lib paths via brew --prefix, supporting both Apple Silicon and Intel Macs.
Author
|
@john-tornblom here is my humble edit to add macOS support. The changes are minimal and I also added an CI job that runs after the original Let me know if we need to adjust this in any way shape or form! Thank you for this great cli! |
Runs on macos-latest after CI completes successfully. Builds with Homebrew curl and uploads arm64 artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add macOS build support: fix basename conflict and add Makefile.macos with Homebrew curl paths.