make graph_vram_allocate() return an aligned pointer#810
Merged
rickgaiser merged 1 commit intops2dev:masterfrom Jan 31, 2026
Merged
make graph_vram_allocate() return an aligned pointer#810rickgaiser merged 1 commit intops2dev:masterfrom
rickgaiser merged 1 commit intops2dev:masterfrom
Conversation
Member
|
LGTM! |
Member
|
Is |
Contributor
Author
|
Yeah, it is as long as it is a power of 2. It is a little bit weird, but I just used the same masking method used in the file already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you
The second call doesn't actually guarantee you a page aligned word address, graph was only aligning the size. I think this is a massive footgun. Speaking as someone who just continuously blew off their foot for the past few hours.
This PR makes it so you are guaranteed to get an aligned pointer.
There is a cost, this can introduce fragmentation since we aren't tracking alignment padding. If you need good recycling of VRAM though, you probably wouldn't be using this bump allocator anyways.