Set sio2 module default variant to newest revision by default#771
Set sio2 module default variant to newest revision by default#771uyjulian wants to merge 2 commits intops2dev:masterfrom
Conversation
|
PR #746 / commit fe8fcb1 causes black screen on OPL. If you ask me, this line is wrong: ps2sdk/iop/system/sio2man/src/sio2man.c Line 502 in ef3e895 But I don't see any of the lines of code from that commit changed in this PR. |
|
OPL uses a different module variant. The main issue I saw was there was no 2000 API module variant of mcman so I added that and made it the default to avoid mixing up API versions. |
I'm not against merging this PR, but you just made it OPL to work by creating this 2000 API variant, and the 1300 variant still looks wrong. Then once done with this, please could you attach some description to this PR, why it is being created, needs, and/or improvements? I'm already quite lost with too many IOP libraries and versions... Thanks |
Use 2000 as default variant Label variants based on version Add mcman 1400 variant
0181cd7 to
c3453d5
Compare
|
The description has been updated. The issue is that 1300 and 1400 versions of sio2man have the same API major version despite changes in locking behavior to handle multitap support. This causes issues (e.g. hangs when waiting on locks) when mixing the module versions between these versions without a clear reason as to why it occurs. The 2000 version has a higher major version, which always has a separate lock reset function, so this avoids the conflicting API as modules targeting older sio2man will now fail with a version mismatch error. |
This PR:
Moves modules out of
systemfolder tosioandinputfoldersRenames the
-oldvariants to-1300Renames the
rvariants to-2000Adds a
-2000variant to mcmanMakes the
-2000variant default