convert ioplib in a standalone iop library#648
Open
israpps wants to merge 4 commits intops2dev:masterfrom
Open
convert ioplib in a standalone iop library#648israpps wants to merge 4 commits intops2dev:masterfrom
israpps wants to merge 4 commits intops2dev:masterfrom
Conversation
Contributor
Author
|
havent tested it yet if the mx4sio driver works normally after this (although it should?) |
rickgaiser
reviewed
Jul 12, 2024
Member
rickgaiser
left a comment
rickgaiser
left a comment
There was a problem hiding this comment.
Good idea, I created this 'ioplib' some time ago, based on sources from elsewhere (OPL I think it was). Since then I've made many copies = bad practice.
For naming consistency, if you name the library modhook which I think covers what the library does better that ioplib, then I think the include header should also be named modhook.h. Also the function names should then begin with something like modhook_* or mh_*.
rickgaiser
reviewed
Nov 6, 2024
| ioplib_hookExportEntry(lib, 46, _46_psio2_pad_transfer_init); | ||
| ioplib_hookExportEntry(lib, 47, _47_psio2_mc_transfer_init); | ||
| ioplib_hookExportEntry(lib, 48, _48_psio2_mtap_transfer_init); | ||
| modhookk_hookExportEntry(lib, 23, _23_psio2_pad_transfer_init); |
Member
There was a problem hiding this comment.
How did the CI build this succesfully? modhookk with double 'k'?
Contributor
Author
There was a problem hiding this comment.
Lol, didn't saw that. Will recheck this later!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are a bunch of IRX modules around (AFAIK) using ioplib:
The Idea is to stop having local copies of ioplib.h and ioplib.c on every project that requires manipulating exports of other modules.
Therefore, converting this into a library wich is part of the PS2SDK seemed like the most reasonable approach, having one implementation for all the use cases. instead of local copies